Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-965] Fix jackson DoS problem #961

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Oct 18, 2018

after jackson fix the problem: FasterXML/jackson-databind#2157
we need to remove these codes, but keep the test case.

@wujimin wujimin changed the title [SCB-695] Fix jackson do s problem [SCB-695] Fix jackson DoS problem Oct 18, 2018
@wujimin wujimin changed the title [SCB-695] Fix jackson DoS problem [SCB-965] Fix jackson DoS problem Oct 18, 2018
@coveralls
Copy link

coveralls commented Oct 18, 2018

Coverage Status

Coverage decreased (-0.06%) to 86.271% when pulling d763f92 on wujimin:fix-jackson-DoS-problem into abdb21a on apache:master.

@liubao68 liubao68 merged commit e17c9fd into apache:master Oct 23, 2018
@wujimin wujimin deleted the fix-jackson-DoS-problem branch December 5, 2018 14:39
jeho0815 added a commit to jeho0815/ServiceComb-Java-Chassis that referenced this pull request Feb 1, 2019
1、update netty to 4.1.28 ncnative to 2.0.14.Final jackson 2.9.8
2、vertximpl and ConnectionBase(just for test) does not have an public construtor, so add the VertxImpl to resolve first, later will be removed
3、DefaultVertxMetrics does not have the vertx parameter, so add an setter method
4、delete the apache#961, jackson has fixed the promblem by FasterXML/jackson-core@b6c54cf
jeho0815 added a commit to jeho0815/ServiceComb-Java-Chassis that referenced this pull request Feb 1, 2019
1、update netty to 4.1.28 ncnative to 2.0.14.Final jackson 2.9.8
2、vertximpl and ConnectionBase(just for test) does not have an public construtor, so add the VertxImpl to resolve first, later will be removed
3、DefaultVertxMetrics does not have the vertx parameter, so add an setter method
4、delete the apache#961, jackson has fixed the promblem by FasterXML/jackson-core@b6c54cf
wujimin pushed a commit that referenced this pull request Feb 18, 2019
* [SCB-1139] update vertx version from 3.5.3 to 3.6.2
1、update netty to 4.1.28 ncnative to 2.0.14.Final jackson 2.9.8
2、vertximpl (just for test) does not have an public construtor, so add the VertxImpl to resolve first, later will be removed
3、DefaultVertxMetrics does not have the vertx parameter, so add an setter method
4、delete the #961, jackson has fixed the promblem by FasterXML/jackson-core@b6c54cf

* remove pseudo :status header of http2 response
* change the three file's license to vertx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants